Skip to content

Fix security issue#1884

Merged
chensuyue merged 3 commits into
mainfrom
FixSEC
Apr 28, 2025
Merged

Fix security issue#1884
chensuyue merged 3 commits into
mainfrom
FixSEC

Conversation

@ZePan110
Copy link
Copy Markdown
Collaborator

@ZePan110 ZePan110 commented Apr 25, 2025

Description

The summary of the proposed changes as long as the relevant motivation and context.

Issues

https://github.com/opea-project/GenAIExamples/security/code-scanning/30

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

List the newly introduced 3rd party dependency if exists.

Tests

https://github.com/opea-project/GenAIExamples/actions/runs/14698146775/job/41242911239

Copilot AI review requested due to automatic review settings April 25, 2025 05:06
@ZePan110 ZePan110 requested a review from chensuyue as a code owner April 25, 2025 05:06
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Apr 25, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

None

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a security issue by introducing an input validation step in the workflow.

  • Adds a new "Validate Inputs" step in the Helm E2E workflow.
  • Implements a case statement to check the validity of the input example.

Comment thread .github/workflows/_helm-e2e.yml Outdated
Comment thread .github/workflows/_helm-e2e.yml Outdated
@ZePan110 ZePan110 force-pushed the FixSEC branch 4 times, most recently from cd20b2f to 998989d Compare April 25, 2025 06:51
Signed-off-by: ZePan110 <ze.pan@intel.com>
Comment thread .github/workflows/_helm-e2e.yml Outdated
Signed-off-by: ZePan110 <ze.pan@intel.com>
@chensuyue chensuyue merged commit 13c4749 into main Apr 28, 2025
24 checks passed
@chensuyue chensuyue deleted the FixSEC branch April 28, 2025 05:52
@ZePan110 ZePan110 restored the FixSEC branch April 28, 2025 06:03
@ZePan110 ZePan110 deleted the FixSEC branch April 28, 2025 06:03
yongfengdu pushed a commit to yongfengdu/GenAIExamples that referenced this pull request May 8, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
letonghan added a commit that referenced this pull request Sep 17, 2025
Signed-off-by: letonghan <letong.han@intel.com>
cogniware-devops pushed a commit to Cogniware-Inc/GenAIExamples that referenced this pull request Dec 19, 2025
Signed-off-by: ZePan110 <ze.pan@intel.com>
Signed-off-by: cogniware-devops <ambarish.desai@cogniware.ai>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants